Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 1589953005: Support InputMethodManager#updateCursorAnchorInfo for Android 5.0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Findbugs warning / Simplify the state transition. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index aab7ecafbd0a15b6bac63a572ac2387791c065a1..99faddb5f9e26b44cd599ff17e895a99739317ab 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -28,6 +28,10 @@
#include "ui/gfx/geometry/rect_f.h"
#include "url/gurl.h"
+namespace cc {
+struct ViewportSelectionBound;
+}
+
namespace ui {
class WindowAndroid;
}
@@ -305,6 +309,7 @@ class ContentViewCoreImpl : public ContentViewCore,
void HideSelectPopupMenu();
// All sizes and offsets are in CSS pixels as cached by the renderer.
+ // Selection bounds are in DIP coordinates.
aelias_OOO_until_Jul13 2016/02/10 08:23:41 This comment may cause confusion because it makes
aelias_OOO_until_Jul13 2016/02/24 03:16:39 where CSS*mPageScaleFactor==DIP (and DIP*mDeviceSc
void UpdateFrameInfo(const gfx::Vector2dF& scroll_offset,
float page_scale_factor,
const gfx::Vector2dF& page_scale_factor_limits,
@@ -312,7 +317,8 @@ class ContentViewCoreImpl : public ContentViewCore,
const gfx::SizeF& viewport_size,
const gfx::Vector2dF& controls_offset,
const gfx::Vector2dF& content_offset,
- bool is_mobile_optimized_hint);
+ bool is_mobile_optimized_hint,
+ const cc::ViewportSelectionBound& selection_start);
void ForceUpdateImeAdapter(long native_ime_adapter);
void UpdateImeAdapter(long native_ime_adapter,

Powered by Google App Engine
This is Rietveld 408576698