Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1589913003: MIPS: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple.

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [Interpreter] Add ForInPrepare runtime function which returns a ObjectTriple. Port for https://codereview.chromium.org/1576093004/ Original commit message: Adds a ForInPrepare Runtime function which returns a triple of cache_type, cache_array and cache_length. This requires adding support to CEntryStub to call runtime functions which return a ObjectTriple - a struct containing three Object* pointers. Also did some cleanup of the x64 CEntryStub to avoid replicated code. Replaces the interpreter's use of the ad-hock InterpreterForInPrepare Runtime function with ForInPrepare in preparation for fixing deopt in BytecodeGraphBuilder for ForIn (which will be done in a followup CL). BUG=v8:4280 LOG=N

Patch Set 1 #

Patch Set 2 : Fix a0 <-> v0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -26 lines) Patch
M src/mips/code-stubs-mips.cc View 1 2 chunks +39 lines, -11 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 3 chunks +25 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 chunks +39 lines, -10 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 4 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
balazs.kilvady
4 years, 11 months ago (2016-01-14 17:43:05 UTC) #2
On sims we are good, on both mipsel and mip64el sim has exactly the same
failures as before aplying the ported CL.

Powered by Google App Engine
This is Rietveld 408576698