Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp - Issue 15899009: Support indexed setter generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

Issue 15899009: Support indexed setter generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: make helper function and useit Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

index 5aefc0bc6233ee14dbe49e157ffaf79b3f53fb7b..3ad654a1e46d65221971e6ea6cfe5d446bbc1b61 100644

--- a/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

@@ -44,12 +44,6 @@

namespace WebCore {

-v8::Handle<v8::Value> V8HTMLSelectElement::indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)

- HTMLSelectElement* select = V8HTMLSelectElement::toNative(info.Holder());

- return toOptionsCollectionSetter(index, value, select, info.GetIsolate());

v8::Handle<v8::Value> V8HTMLSelectElement::removeMethodCustom(const v8::Arguments& args)

{

HTMLSelectElement* imp = V8HTMLSelectElement::toNative(args.Holder());