Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp - Issue 15899009: Support indexed setter generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 15899009: Support indexed setter generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Use TreatNullAs, TreatUndefinedAs in case of value is null/undefined Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

index b8910b51610eaa5cb6c8c28751c0747adb3ca230..0c3b0198d981bb8cba6c1304f08d194bee2a00a4 100644

--- a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

@@ -123,11 +123,4 @@ void V8HTMLOptionsCollection::lengthAttrSetterCustom(v8::Local<v8::String> name,

setDOMException(ec, info.GetIsolate());

}

-v8::Handle<v8::Value> V8HTMLOptionsCollection::indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)

- HTMLOptionsCollection* collection = V8HTMLOptionsCollection::toNative(info.Holder());

- HTMLSelectElement* base = toHTMLSelectElement(collection->ownerNode());

- return toOptionsCollectionSetter(index, value, base, info.GetIsolate());

} // namespace WebCore