Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1589823007: Generate enum readers. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate enum readers. This is just nicer for the clients, plus also will allow us to use these readers in lists. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6f5082ea7c6739a83a836a4d3eb34f41accd5559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -24 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +44 lines, -5 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 4 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-15 22:36:58 UTC) #1
Paul Berry
lgtm
4 years, 11 months ago (2016-01-15 23:02:03 UTC) #2
scheglov
4 years, 11 months ago (2016-01-15 23:06:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f5082ea7c6739a83a836a4d3eb34f41accd5559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698