Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1589733004: CSS Typed OM: add TransformComponents Rotation and Skew (Closed)

Created:
4 years, 11 months ago by tridgell
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@cssValueAndCssString
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Typed OM: add TransformComponents Rotation and Skew Adds RotationTransformComponent and SkewTransformComponent. Changes the name of RotateType to RotationType in TransformComponentType enum to match class names. BUG=545318 Spec: https://drafts.css-houdini.org/css-typed-om/#transformcomponent Committed: https://crrev.com/ee395332482fd648431a36356392eb2c9ab88e78 Cr-Commit-Position: refs/heads/master@{#371682}

Patch Set 1 #

Patch Set 2 : Change to appendLiteral. Move headers to .cpp #

Total comments: 1

Patch Set 3 : Rebase and remove cssString methods #

Total comments: 10

Patch Set 4 : Remove TransformComponent call in child constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -13 lines) Patch
A third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.cpp View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ScaleTransformComponent.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.idl View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformComponent.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
tridgell
4 years, 11 months ago (2016-01-17 23:01:37 UTC) #2
meade_UTC10
lgtm from my point of view https://codereview.chromium.org/1589733004/diff/20001/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h File third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h (right): https://codereview.chromium.org/1589733004/diff/20001/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h#newcode13 third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h:13: WTF_MAKE_NONCOPYABLE(RotationTransformComponent); It actually ...
4 years, 11 months ago (2016-01-18 05:37:38 UTC) #4
tridgell
On 2016/01/18 05:37:38, Eddy wrote: > lgtm from my point of view > > https://codereview.chromium.org/1589733004/diff/20001/third_party/WebKit/Source/core/css/cssom/RotationTransformComponent.h ...
4 years, 11 months ago (2016-01-20 03:46:56 UTC) #5
Timothy Loh
ok lgtm, but for the future please split up patches like this (the rotation and ...
4 years, 11 months ago (2016-01-25 00:49:09 UTC) #6
tridgell
Noted to make them into separate CLs next time. https://codereview.chromium.org/1589733004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html File third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html (right): https://codereview.chromium.org/1589733004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html#newcode22 third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html:22: ...
4 years, 11 months ago (2016-01-27 00:23:39 UTC) #10
tridgell
https://codereview.chromium.org/1589733004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html File third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html (right): https://codereview.chromium.org/1589733004/diff/40001/third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html#newcode46 third_party/WebKit/LayoutTests/typedcssom/rotationTransformComponent.html:46: <body> On 2016/01/25 00:49:08, Timothy Loh wrote: > no ...
4 years, 11 months ago (2016-01-27 00:36:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589733004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589733004/60001
4 years, 11 months ago (2016-01-27 00:38:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589733004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589733004/60001
4 years, 11 months ago (2016-01-27 00:45:52 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-27 01:45:46 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 01:46:58 UTC) #22
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ee395332482fd648431a36356392eb2c9ab88e78
Cr-Commit-Position: refs/heads/master@{#371682}

Powered by Google App Engine
This is Rietveld 408576698