third_party/WebKit/Source/platform/exported/WebURLResponse.cpp - Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only send the SCT counts. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('K') | « third_party/WebKit/Source/devtools/protocol.json ('k') | third_party/WebKit/Source/platform/network/ResourceResponse.h » ('j') | third_party/WebKit/public/platform/WebURLResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

index d00ddd259fa4b0f1d6dc84b040333b64cb993578..e89a8848cad0e70f3ca237c2758b2812cdb4a890 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

@@ -321,9 +321,9 @@ void WebURLResponse::setSecurityStyle(SecurityStyle securityStyle)

m_private->m_resourceResponse->setSecurityStyle(static_cast<ResourceResponse::SecurityStyle>(securityStyle));

}

-void WebURLResponse::setSecurityDetails(const WebString& protocol, const WebString& keyExchange, const WebString& cipher, const WebString& mac, int certId)

+void WebURLResponse::setSecurityDetails(const WebString& protocol, const WebString& keyExchange, const WebString& cipher, const WebString& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts)

{

- m_private->m_resourceResponse->setSecurityDetails(protocol, keyExchange, cipher, mac, certId);

+ m_private->m_resourceResponse->setSecurityDetails(protocol, keyExchange, cipher, mac, certId, numUnknownScts, numInvalidScts, numValidScts);

}

ResourceResponse& WebURLResponse::toMutableResourceResponse()