third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js - Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel.

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only send the SCT counts. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | third_party/WebKit/public/platform/WebURLResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

index b678592b1d8e501e9c63e55d56f554d6d7047022..9a9312f157bcd5a3cc9b8b5835a3f32f55a19ec9 100644

--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

@@ -798,8 +798,8 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)

table.addRow("Valid From", validFromString);

table.addRow("Valid Until", validUntilString);

table.addRow("Issuer", certificateDetails.issuer);

+ table.addRow("SCTs", WebInspector.UIString(this.sctSummary(originState.securityDetails.certificateValidationDetails)));

table.addRow("", WebInspector.SecurityPanel.createCertificateViewerButton(WebInspector.UIString("Open full certificate details"), originState.securityDetails.certificateId));

- // TODO(lgarron): Make SCT status available in certificate details and show it here.

}

function displayCertificateDetailsUnavailable ()

@@ -879,6 +879,27 @@ WebInspector.SecurityOriginView.prototype = {

this._originLockIcon.classList.add("security-property-" + newSecurityState);

+ /**

+ * @constructor

+ * @param {?NetworkAgent.CertificateValidationDetails} details

+ * @return {string}

+ */

+ sctSummary: function(details)

+ {

+ if (!details) {

pfeldman 2016/02/01 23:01:11 drop {}

lgarron 2016/02/02 03:17:07 Done.

+ return "N/A";

pfeldman 2016/02/01 23:01:11 WebInspector.UIString()

lgarron 2016/02/02 03:17:07 Done. (I've also removed the WebInspector.UIString

+ }

+ var sctTypeList = [];

+ if (details.numValidScts)

+ sctTypeList.push(WebInspector.UIString("%d valid SCT%s", details.numValidScts, (details.numValidScts > 1) ? "s" : ""));

+ if (details.numInvalidScts)

+ sctTypeList.push(WebInspector.UIString("%d invalid SCT%s", details.numInvalidScts, (details.numInvalidScts > 1) ? "s" : ""));

+ if (details.numUnknownScts)

+ sctTypeList.push(WebInspector.UIString("%d SCT%s from unknown logs", details.numUnknownScts, (details.numUnknownScts > 1) ? "s" : ""));

+ return (sctTypeList.length == 0) ? WebInspector.UIString("0 SCTs") : sctTypeList.join(", ");

pfeldman 2016/02/01 23:01:11 sctTypeList.length ? ...

lgarron 2016/02/02 03:17:07 Done. It still makes me uncomfortable, though, an

+ },

__proto__: WebInspector.VBox.prototype

}