Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments by rsleevi@ and pfeldman@. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
index d96e8b0e854246769b4d39a554e3f8b21ea1ee3f..e899e43ef599b96686c3a158265037663586567d 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
@@ -75,6 +75,7 @@
#include "public/platform/WebURLRequest.h"
#include "wtf/CurrentTime.h"
#include "wtf/RefPtr.h"
+#include "wtf/StdLibExtras.h"
#include "wtf/text/Base64.h"
typedef blink::InspectorBackendDispatcher::NetworkCommandHandler::GetResponseBodyCallback GetResponseBodyCallback;
@@ -384,11 +385,23 @@ static PassRefPtr<TypeBuilder::Network::Response> buildObjectForResourceResponse
const ResourceResponse::SecurityDetails* responseSecurityDetails = response.securityDetails();
+ int numUnknownSCTs = safeCast<int>(responseSecurityDetails->numUnknownSCTs);
+ int numInvalidSCTs = safeCast<int>(responseSecurityDetails->numInvalidSCTs);
+ int numValidSCTs = safeCast<int>(responseSecurityDetails->numValidSCTs);
+
+ // TODO: Safe cast
+ RefPtr<TypeBuilder::Network::CertificateValidationDetails> certificateValidationDetails = TypeBuilder::Network::CertificateValidationDetails::create()
+ .setIsValidEv(responseSecurityDetails->certIsValidEV)
+ .setNumUnknownScts(numUnknownSCTs)
+ .setNumInvalidScts(numInvalidSCTs)
+ .setNumValidScts(numValidSCTs);
+
RefPtr<TypeBuilder::Network::SecurityDetails> securityDetails = TypeBuilder::Network::SecurityDetails::create()
.setProtocol(responseSecurityDetails->protocol)
.setKeyExchange(responseSecurityDetails->keyExchange)
.setCipher(responseSecurityDetails->cipher)
.setCertificateId(responseSecurityDetails->certID);
+ securityDetails->setCertificateValidationDetails(certificateValidationDetails);
if (responseSecurityDetails->mac.length() > 0)
securityDetails->setMac(responseSecurityDetails->mac);

Powered by Google App Engine
This is Rietveld 408576698