Issue 15897010: Revert 201479 "Make InputMethodWin TSF-aware."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15897010: Revert 201479 "Make InputMethodWin TSF-aware." (Closed)

Created:
7 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 6 months ago

Reviewers:
yukawa

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 201479 "Make InputMethodWin TSF-aware." This is breaking chrome on windows 8, can't relaunch in desktop see bug BUG=244453 > Make InputMethodWin TSF-aware. > > This patch set introduces following event handlings > so that InputMethodWin can work with TSF-based IME. > - Focus handling (OnFocus/OnBlur) > - TextInputType handling (OnTextInputTypeChanged) > - Composition Handling (OnDidChangeFocus/ConfirmCompositionText) > > Basically this is just a quick fix and InputMethodWin > should be refactored eventually. > > BUG=239690 > TEST=Manually done on Windows 7 with --enable-text-services-framework > > Review URL: https://chromiumcodereview.appspot.com/14698032 TBR=Yukawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202709

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -140 lines)			Patch
M	trunk/src/ui/base/ime/win/mock_tsf_bridge.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/ui/base/ime/win/mock_tsf_bridge.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	trunk/src/ui/base/ime/win/tsf_bridge.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/ui/base/ime/win/tsf_bridge.cc	View	5 chunks	+14 lines, -28 lines	0 comments	Download
M	trunk/src/ui/views/ime/input_method_win.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/ime/input_method_win.cc	View	7 chunks	+32 lines, -96 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r202709.

Expand Messages | Collapse Messages