Identity API: switch WebAuthFlow dialog to component app

Identity API: switch WebAuthFlow dialog to component app

All Identity API UI is moving into a webview tag inside a component
app, allowing Chrome Apps to be isolated from the browser.

This change updates WebAuthFlow, which controls the dialogs, to invoke
the component app instead of a browser pop-up.

BUG=228908
(This is part of step #6 in the description.)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203417

[Michael Courage, 2013-05-24 01:32:26]

Last piece of the component app puzzle.

[miket_OOO, 2013-05-24 16:37:55]

lgtm

https://codereview.chromium.org/15897006/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/identity_apitest.cc (right):

https://codereview.chromium.org/15897006/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/identity_apitest.cc:214:
content::WindowedNotificationObserver::Observe(type, source, details);
Did you mean to call the inherited behavior only conditionally on == url_?

[Michael Courage, 2013-05-30 22:26:25]

PTAL: WebAuthFlow now checks to see if it needs to load the component app
itself, since loading it from ComponentLoader was causing memory test
unhappiness.

cc mpcomplete@ who reviewed https://codereview.chromium.org/15892012/#ps1, where
I first attempted a deferred load, before deciding to move it here.

[Michael Courage, 2013-05-30 22:27:03]

https://codereview.chromium.org/15897006/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/identity_apitest.cc (right):

https://codereview.chromium.org/15897006/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/identity_apitest.cc:214:
content::WindowedNotificationObserver::Observe(type, source, details);
On 2013/05/24 16:37:56, miket wrote:
> Did you mean to call the inherited behavior only conditionally on == url_?

Yes, added a comment to that effect.

[Matt Perry, 2013-05-30 22:50:49]

lgtm

[commit-bot: I haz the power, 2013-05-31 14:25:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/15897006/18001

[commit-bot: I haz the power, 2013-05-31 16:29:26]

Change committed as 203417