Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: net/cookies/parsed_cookie.h

Issue 15897003: Added UMA measurement for how often we see control characters during cookie parsing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed missing brackets that were causing unit test failure. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/cookies/parsed_cookie.cc » ('j') | net/cookies/parsed_cookie.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_COOKIES_PARSED_COOKIE_H_ 5 #ifndef NET_COOKIES_PARSED_COOKIE_H_
6 #define NET_COOKIES_PARSED_COOKIE_H_ 6 #define NET_COOKIES_PARSED_COOKIE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // We're really never going to have more than like 8 attributes, so we 132 // We're really never going to have more than like 8 attributes, so we
133 // could fit these into 3 bits each if we're worried about size... 133 // could fit these into 3 bits each if we're worried about size...
134 size_t path_index_; 134 size_t path_index_;
135 size_t domain_index_; 135 size_t domain_index_;
136 size_t expires_index_; 136 size_t expires_index_;
137 size_t maxage_index_; 137 size_t maxage_index_;
138 size_t secure_index_; 138 size_t secure_index_;
139 size_t httponly_index_; 139 size_t httponly_index_;
140 size_t priority_index_; 140 size_t priority_index_;
141 141
142 bool parsed_invalid_control_char_;
143
142 DISALLOW_COPY_AND_ASSIGN(ParsedCookie); 144 DISALLOW_COPY_AND_ASSIGN(ParsedCookie);
143 }; 145 };
144 146
145 } // namespace net 147 } // namespace net
146 148
147 #endif // NET_COOKIES_COOKIE_MONSTER_H_ 149 #endif // NET_COOKIES_COOKIE_MONSTER_H_
OLDNEW
« no previous file with comments | « no previous file | net/cookies/parsed_cookie.cc » ('j') | net/cookies/parsed_cookie.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698