Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1589693002: Avoid shutdown leak. (Closed)

Created:
4 years, 11 months ago by jam
Modified:
4 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid shutdown leak in RawChannel and MessgePipeDispatcher. This is to keep LSAN bots happy. BUG=561803, 574325 TBR=ben Committed: https://crrev.com/d8a022e9822b5b7734b0f7389480cdcdb65c9cb2 Cr-Commit-Position: refs/heads/master@{#369332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
jam
This is split off from the already reviewed https://codereview.chromium.org/1554443003/, to land it earlier to see ...
4 years, 11 months ago (2016-01-14 01:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589693002/1
4 years, 11 months ago (2016-01-14 01:41:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 02:39:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589693002/1
4 years, 11 months ago (2016-01-14 03:14:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/152145)
4 years, 11 months ago (2016-01-14 03:49:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589693002/1
4 years, 11 months ago (2016-01-14 03:58:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 05:08:53 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:09:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8a022e9822b5b7734b0f7389480cdcdb65c9cb2
Cr-Commit-Position: refs/heads/master@{#369332}

Powered by Google App Engine
This is Rietveld 408576698