Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1589663002: fixes #25407, generic list and map literal type comments (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jennifer Messerly
4 years, 11 months ago (2016-01-14 00:09:51 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-14 00:56:16 UTC) #3
Brian Wilkerson
Wait, why do we need this? Why not just use the normal syntax?
4 years, 11 months ago (2016-01-14 00:57:20 UTC) #4
Jennifer Messerly
On 2016/01/14 00:57:20, Brian Wilkerson wrote: > Wait, why do we need this? Why not ...
4 years, 11 months ago (2016-01-14 01:05:04 UTC) #5
Brian Wilkerson
OK, that makes sense. LGTM
4 years, 11 months ago (2016-01-14 01:06:21 UTC) #6
Jennifer Messerly
4 years, 11 months ago (2016-01-14 21:19:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
154959c762c8ceffd7de5bf4e6269daa9693a116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698