Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.h

Issue 1589643003: OOPIF support for testRunner.dumpAsText and similar layout dumps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing... Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.h
diff --git a/content/shell/renderer/layout_test/blink_test_runner.h b/content/shell/renderer/layout_test/blink_test_runner.h
index 4b62441281535feca82f7ccdabf6493e167a8e00..2a0270b49fb8c5f79b8e203b01deabb722f6f6e8 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.h
+++ b/content/shell/renderer/layout_test/blink_test_runner.h
@@ -41,6 +41,8 @@ class LeakDetector;
struct LeakDetectionResult;
// This is the renderer side of the webkit test runner.
+// TODO(lukasza): Rename to LayoutTestRenderViewObserver for consistency with
+// LayoutTestRenderFrameObserver.
class BlinkTestRunner : public RenderViewObserver,
public RenderViewObserverTracker<BlinkTestRunner>,
public test_runner::WebTestDelegate {
@@ -177,7 +179,9 @@ class BlinkTestRunner : public RenderViewObserver,
// After finishing the test, retrieves the audio, text, and pixel dumps from
// the TestRunner library and sends them to the browser process.
void CaptureDump();
- void CaptureDumpPixels(const SkBitmap& snapshot);
+ void OnLayoutDumpCompleted(std::string completed_layout_dump);
+ void CaptureDumpContinued();
+ void OnPixelsDumpCompleted(const SkBitmap& snapshot);
void CaptureDumpComplete();
test_runner::WebTestProxyBase* proxy_;
« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698