third_party/WebKit/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html - Issue 1589643003: OOPIF support for testRunner.dumpAsText and similar layout dumps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html

Issue 1589643003: OOPIF support for testRunner.dumpAsText and similar layout dumps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready for review. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <div>Test passes if it does not crash.</div>	2 <div>Test passes if it does not crash.</div>

3 <script src="../tests.js"></script>	3 <script src="../tests.js"></script>

4 <style>	4 <style>

5 @font-face {	5 @font-face {

6 font-family: CanvasTest;	6 font-family: CanvasTest;

7 src: url("does_not_exist.ttf");	7 src: url("does_not_exist.ttf");

8 }	8 }

9 </style>	9 </style>

10 <applet>	10 <applet>

11 <canvas id="c">	11 <canvas id="c">

12 </applet>	12 </applet>

13 <ul id="d"></ul>	13 <ul id="d"></ul>

14 <script>	14 <script>

15 if (window.testRunner)	15 if (window.testRunner)

16 testRunner.dumpAsText();	16 testRunner.dumpAsText();

17	17

18 _addTest(function(canvas, ctx) {	18 _addTest(function(canvas, ctx) {

19	19

20 ctx.fillRect(0, 0, 100, 50);	20 ctx.fillRect(0, 0, 100, 50);

21 ctx.font = '1px CanvasTest';	21 ctx.font = '1px CanvasTest';

22 ctx.fillText('AA', 0, 50);	22 ctx.fillText('AA', 0, 50);

23 deferTest();	23 deferTest();

24	24

25 setTimeout(wrapFunction(function () {	25 setTimeout(wrapFunction(function () {

26 ctx.fillText('AA', 0, 50);	26 ctx.fillText('AA', 0, 50);

27	27

	28 _assert(true, "Test passes if it does not crash.")
	dcheng 2016/01/23 05:17:33 Not sure if I missed this a comment about this, bu Not sure if I missed this a comment about this, but what's the reason for this test change? Łukasz Anforowicz 2016/01/26 00:50:02 This change is not necessary in the latest patchse Show quoted text On 2016/01/23 05:17:33, dcheng wrote: > Not sure if I missed this a comment about this, but what's the reason for this > test change? This change is not necessary in the latest patchset - I've removed it. When testing earlier patchsets I've noted that LayoutTests/canvas/philip/tests.js:122 should fail a test if the test didn't call any of the _assertFoo functions. The modified test did fail with my earlier changes, without the extra call to _assert. I don't understand why the test is passing without my changes and with my latest changes.
28 if (window.testRunner)	29 if (window.testRunner)

29 testRunner.notifyDone();	30 testRunner.notifyDone();

30 }), 500);	31 }), 500);

31	32

32 });	33 });

33 </script>	34 </script>

OLD	NEW

« components/test_runner/layout_dump_flags.h ('K') | « content/shell/renderer/layout_test/layout_test_render_frame_observer.cc ('k') | no next file » | no next file with comments »