runtime/vm/flow_graph_compiler_ia32.cc - Issue 1589643002: Source positions for constructors and lots of async machinery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1589643002: Source positions for constructors and lots of async machinery (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index b2272fe9a9593076348e81e76048b7f1f7eb84ad..8152b3d85d4e99768ea96813cd8b3f215d4c796d 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -684,7 +684,7 @@ void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos,

const AbstractType& dst_type,

const String& dst_name,

LocationSummary* locs) {

- ASSERT(Scanner::ValidSourcePosition(token_pos));

+ ASSERT(!Token::IsClassifying(token_pos));

ASSERT(!dst_type.IsNull());

ASSERT(dst_type.IsFinalized());

// Assignable check is skipped in FlowGraphBuilder, not here.

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »