Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1589643002: Source positions for constructors and lots of async machinery (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder_test.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 // - R1: instantiator type arguments or raw_null. 666 // - R1: instantiator type arguments or raw_null.
667 // Returns: 667 // Returns:
668 // - object in R0 for successful assignable check (or throws TypeError). 668 // - object in R0 for successful assignable check (or throws TypeError).
669 // Performance notes: positive checks must be quick, negative checks can be slow 669 // Performance notes: positive checks must be quick, negative checks can be slow
670 // as they throw an exception. 670 // as they throw an exception.
671 void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos, 671 void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos,
672 intptr_t deopt_id, 672 intptr_t deopt_id,
673 const AbstractType& dst_type, 673 const AbstractType& dst_type,
674 const String& dst_name, 674 const String& dst_name,
675 LocationSummary* locs) { 675 LocationSummary* locs) {
676 ASSERT(Scanner::ValidSourcePosition(token_pos)); 676 ASSERT(!Token::IsClassifying(token_pos));
677 ASSERT(!dst_type.IsNull()); 677 ASSERT(!dst_type.IsNull());
678 ASSERT(dst_type.IsFinalized()); 678 ASSERT(dst_type.IsFinalized());
679 // Assignable check is skipped in FlowGraphBuilder, not here. 679 // Assignable check is skipped in FlowGraphBuilder, not here.
680 ASSERT(dst_type.IsMalformedOrMalbounded() || 680 ASSERT(dst_type.IsMalformedOrMalbounded() ||
681 (!dst_type.IsDynamicType() && !dst_type.IsObjectType())); 681 (!dst_type.IsDynamicType() && !dst_type.IsObjectType()));
682 // Preserve instantiator type arguments (R1). 682 // Preserve instantiator type arguments (R1).
683 __ Push(R1); 683 __ Push(R1);
684 // A null object is always assignable and is returned as result. 684 // A null object is always assignable and is returned as result.
685 Label is_assignable, runtime_call; 685 Label is_assignable, runtime_call;
686 __ CompareObject(R0, Object::null_object()); 686 __ CompareObject(R0, Object::null_object());
(...skipping 1245 matching lines...) Expand 10 before | Expand all | Expand 10 after
1932 DRegister dreg = EvenDRegisterOf(reg); 1932 DRegister dreg = EvenDRegisterOf(reg);
1933 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1933 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1934 } 1934 }
1935 1935
1936 1936
1937 #undef __ 1937 #undef __
1938 1938
1939 } // namespace dart 1939 } // namespace dart
1940 1940
1941 #endif // defined TARGET_ARCH_ARM 1941 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder_test.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698