Issue 158963004: Merge 249240 "Close the correct end of the BIO pair on transport..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158963004: Merge 249240 "Close the correct end of the BIO pair on transport..." (Closed)

Created:
6 years, 10 months ago by davidben

Modified:
6 years, 10 months ago

Reviewers:
davidben

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1750/src/

Visibility:
Public.

More Reviews

Description

Merge 249240 "Close the correct end of the BIO pair on transport..." > Close the correct end of the BIO pair on transport send failures in openssl. > > Shut down the end of the BIO pair which OpenSSL is writing to, not the > transport socket. However, retain the transport_bio_ shutdown to mirror the > behavior of NSS in r206751, to avoid breaking > SSLClientSocketTest.Write_WithSynchronousError and potentially regressing > http://crbug.com/249848. > > To avoid the CHECK in TransportReadComplete, handle the collision of write > failures and pending reads by propogating the write failure. > > Remove BIO_set_mem_eof_return calls because they don't do anything. These > aren't mem BIOs. > > BUG=335557 > TEST=SSLClientSocketTest.Read_WithWriteError > > Review URL: https://codereview.chromium.org/148213019 TBR=davidben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250123

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -6 lines)			Patch
M	net/socket/ssl_client_socket_openssl.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	net/socket/ssl_client_socket_openssl.cc	View	8 chunks	+24 lines, -5 lines	0 comments	Download
M	net/socket/ssl_client_socket_unittest.cc	View	1 chunk	+106 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r250123.

Expand Messages | Collapse Messages