Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 1589623002: Keep track of accessibility focus across windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final suggestions Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/platform/ax_platform_node_win.cc
diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc
index ee7a4f9f8c6981ec7fe7c1d28eea79f781daa01f..574ffab925c28e1c2b7dce1223c5e91dff9f89d7 100644
--- a/ui/accessibility/platform/ax_platform_node_win.cc
+++ b/ui/accessibility/platform/ax_platform_node_win.cc
@@ -982,8 +982,6 @@ int AXPlatformNodeWin::MSAAState() {
msaa_state |= STATE_SYSTEM_EXPANDED;
if (state & (1 << ui::AX_STATE_FOCUSABLE))
msaa_state |= STATE_SYSTEM_FOCUSABLE;
- if (state & (1 << ui::AX_STATE_FOCUSED))
- msaa_state |= STATE_SYSTEM_FOCUSED;
if (state & (1 << ui::AX_STATE_HASPOPUP))
msaa_state |= STATE_SYSTEM_HASPOPUP;
if (state & (1 << ui::AX_STATE_HOVERED))
@@ -1007,6 +1005,15 @@ int AXPlatformNodeWin::MSAAState() {
if (state & (1 << ui::AX_STATE_DISABLED))
msaa_state |= STATE_SYSTEM_UNAVAILABLE;
+ gfx::NativeViewAccessible focus = delegate_->GetFocus();
+ if (focus == GetNativeViewAccessible())
+ msaa_state |= STATE_SYSTEM_FOCUSED;
+
+ // On Windows, the "focus" bit should be set on certain containers, like
+ // menu bars, when one of their children has focus.
+ if (GetData().role == ui::AX_ROLE_MENU_BAR && focus)
+ msaa_state |= STATE_SYSTEM_FOCUSED;
+
return msaa_state;
}
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_auralinux.cc ('k') | ui/app_list/views/search_result_actions_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698