content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 1589623002: Keep track of accessibility focus across windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 1589623002: Keep track of accessibility focus across windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final suggestions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index ac99237d8416d7add9d26fc4a04a887aeb7b3ea8..1ad022c08abca217f0ca40847adeb8a192f48ba5 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -24,9 +24,6 @@ uint32_t AXStateFromBlink(const blink::WebAXObject& o) {

if (o.canSetFocusAttribute())

state |= (1 << ui::AX_STATE_FOCUSABLE);

- if (o.isFocused())

- state |= (1 << ui::AX_STATE_FOCUSED);

if (o.role() == blink::WebAXRolePopUpButton ||

o.ariaHasPopup())

state |= (1 << ui::AX_STATE_HASPOPUP);