content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1589623002: Keep track of accessibility focus across windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1589623002: Keep track of accessibility focus across windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final suggestions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index a73a09ff790015c68ed33b744e1bbc1f3c9dd1a0..866a803fe6d59c97ca04fa788f8abc2f074e42b4 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2829,7 +2829,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(

renderWidgetHostView_->render_widget_host_

->GetRootBrowserAccessibilityManager();

if (manager) {

- BrowserAccessibility* focused_item = manager->GetFocus(NULL);

+ BrowserAccessibility* focused_item = manager->GetFocus();

DCHECK(focused_item);

if (focused_item) {

BrowserAccessibilityCocoa* focused_item_cocoa =