content/browser/accessibility/browser_accessibility_manager_win.cc - Issue 1589623002: Keep track of accessibility focus across windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_win.cc

Issue 1589623002: Keep track of accessibility focus across windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final suggestions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_win.cc b/content/browser/accessibility/browser_accessibility_manager_win.cc

index 4f963ebcb02c2909e3ac4780816503a29ac0d371..a02cc9a4e1e5478807b73f15b5233838aad5026d 100644

--- a/content/browser/accessibility/browser_accessibility_manager_win.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_win.cc

@@ -173,7 +173,7 @@ void BrowserAccessibilityManagerWin::OnWindowFocused() {

// Try to fire a focus event on the root first and then the focused node.

// This will clear focus_event_on_root_needed_ if successful.

- if (focus_ != tree_->root() && GetRoot())

+ if (GetFocus() != GetRoot() && GetRoot())

NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, GetRoot());

BrowserAccessibilityManager::OnWindowFocused();

inside_on_window_focused_ = false;