content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 1589623002: Keep track of accessibility focus across windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1589623002: Keep track of accessibility focus across windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final suggestions Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/accessibility/browser_accessibility_manager_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 6c48f4476dafa0864966f66af33519c0db4085c3..99000dd766598b92efc22d963b2d6af7c5c981f6 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -143,7 +143,7 @@ void BrowserAccessibilityManagerAndroid::NotifyAccessibilityEvent(

switch (event_type) {

case ui::AX_EVENT_LOAD_COMPLETE:

Java_BrowserAccessibilityManager_handlePageLoaded(

- env, obj.obj(), focus_->id());

+ env, obj.obj(), GetFocus()->GetId());

break;

case ui::AX_EVENT_FOCUS:

Java_BrowserAccessibilityManager_handleFocusChanged(

@@ -183,7 +183,7 @@ void BrowserAccessibilityManagerAndroid::NotifyAccessibilityEvent(

break;

case ui::AX_EVENT_TEXT_CHANGED:

case ui::AX_EVENT_VALUE_CHANGED:

- if (android_node->IsEditableText() && GetFocus(GetRoot()) == node) {

+ if (android_node->IsEditableText() && GetFocus() == node) {

Java_BrowserAccessibilityManager_handleEditableTextChanged(

env, obj.obj(), node->GetId());

} else if (android_node->IsSlider()) {

@@ -496,13 +496,13 @@ void BrowserAccessibilityManagerAndroid::Focus(JNIEnv* env,

jint id) {

BrowserAccessibility* node = GetFromID(id);

if (node)

- SetFocus(node, true);

+ SetFocus(*node);

}

void BrowserAccessibilityManagerAndroid::Blur(

JNIEnv* env,

const JavaParamRef<jobject>& obj) {

- SetFocus(GetRoot(), true);

+ SetFocus(*GetRoot());

}

void BrowserAccessibilityManagerAndroid::ScrollToMakeNodeVisible(