Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4391)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 15896026: When comparing emails in the one click signin helper, use the existing utility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 59fc87c678ae878306ee373281f2b81215e00769..9f2546ed13ef51aea7b4d2d355323f56424fc234 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -1184,7 +1184,7 @@ void OneClickSigninHelper::DidStopLoading(
std::string last_email =
profile->GetPrefs()->GetString(prefs::kGoogleServicesLastUsername);
- if (!last_email.empty() && last_email != email_) {
+ if (!gaia::AreEmailsSame(last_email, email_)) {
bcwhite 2013/06/03 20:26:30 I believe you still need to exclude empty addresse
Roger Tawa OOO till Jul 10th 2013/06/04 14:01:25 Good catch! Fixed.
// If the new email address is different from the email address that
// just signed in, show a confirmation dialog.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698