When comparing emails in the one click signin helper, use the existing utility

When comparing emails in the one click signin helper, use the existing utility
function to compare emails instead of doing a string compare.

BUG=244408
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204023

[Roger Tawa OOO till Jul 10th, 2013-06-03 18:35:29]

Hi Brian,

Please take a look.  Thanks.

[bcwhite, 2013-06-03 20:26:30]

https://codereview.chromium.org/15896026/diff/1/chrome/browser/ui/sync/one_cl...
File chrome/browser/ui/sync/one_click_signin_helper.cc (right):

https://codereview.chromium.org/15896026/diff/1/chrome/browser/ui/sync/one_cl...
chrome/browser/ui/sync/one_click_signin_helper.cc:1187: if
(!gaia::AreEmailsSame(last_email, email_)) {
I believe you still need to exclude empty addresses.  We don't want two empty
strings to be considered the same email.

[Roger Tawa OOO till Jul 10th, 2013-06-04 14:01:25]

Thanks Brian.  PTAL.

https://codereview.chromium.org/15896026/diff/1/chrome/browser/ui/sync/one_cl...
File chrome/browser/ui/sync/one_click_signin_helper.cc (right):

https://codereview.chromium.org/15896026/diff/1/chrome/browser/ui/sync/one_cl...
chrome/browser/ui/sync/one_click_signin_helper.cc:1187: if
(!gaia::AreEmailsSame(last_email, email_)) {
On 2013/06/03 20:26:30, bcwhite wrote:
> I believe you still need to exclude empty addresses.  We don't want two empty
> strings to be considered the same email.

Good catch!  Fixed.

[bcwhite, 2013-06-04 14:06:32]

lgtm

[commit-bot: I haz the power, 2013-06-04 14:10:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Roger Tawa OOO till Jul 10th, 2013-06-04 14:28:29]

Salut MAD, can you tale a look?  Thanks.

[MAD, 2013-06-04 15:08:10]

lgtm

[commit-bot: I haz the power, 2013-06-04 15:20:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/15896026/11001

[commit-bot: I haz the power, 2013-06-04 20:10:42]

Change committed as 204023