Better focus traversal during LMU creation

Better focus traversal during LMU creation

BUG=229762
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203960

[Nikita (slow), 2013-06-03 15:55:43]

lgtm

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
File
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js
(right):

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:242:
this.checkUserName_.bind(this),
nit: Please fix parameter alignment for all calls to this.configureTextInput()

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:300:
validIfNotEmpty: function(element) {
private, should end with _

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:305:
* Configure text-input |element|
nit: dot is missing.

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:317:
configureTextInput: function(element,
private, should end with _

https://codereview.chromium.org/15896016/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:318:
inputChangeListener,
nit: Please fix alignment.

[Denis Kuznetsov (DE-MUC), 2013-06-03 16:33:04]

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
File
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js
(right):

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:242:
this.checkUserName_.bind(this),
On 2013/06/03 15:55:43, Nikita Kostylev wrote:
> nit: Please fix parameter alignment for all calls to this.configureTextInput()

Done.

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:300:
validIfNotEmpty: function(element) {
On 2013/06/03 15:55:43, Nikita Kostylev wrote:
> private, should end with _

Done.

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:305:
* Configure text-input |element|
On 2013/06/03 15:55:43, Nikita Kostylev wrote:
> nit: dot is missing.

Done.

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:317:
configureTextInput: function(element,
On 2013/06/03 15:55:43, Nikita Kostylev wrote:
> private, should end with _
At some point it will be moved to parent class.

https://chromiumcodereview.appspot.com/15896016/diff/1/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js:318:
inputChangeListener,
On 2013/06/03 15:55:43, Nikita Kostylev wrote:
> nit: Please fix alignment.

Done.

[commit-bot: I haz the power, 2013-06-03 16:33:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/15896016/5001

[commit-bot: I haz the power, 2013-06-04 06:18:37]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-06-04 13:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/15896016/5001

[commit-bot: I haz the power, 2013-06-04 14:00:41]

Change committed as 203960