[SystemInfo API] Rewrite storage info provider using storage monitor impl

chrome/browser/storage_monitor/storage_monitor.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_STORAGE_MONITOR_STORAGE_MONITOR_H_
 #define CHROME_BROWSER_STORAGE_MONITOR_STORAGE_MONITOR_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 55 matching lines @@
 
   // Initialize the storage monitor. The provided callback, if non-null,
   // will be called when initialization is complete. If initialization has
   // already completed, this callback will be invoked within the calling stack.
   // Before the callback is run, calls to |GetAttachedStorage| and
   // |GetStorageInfoForPath| may not return the correct results. In addition,
   // registered observers will not be notified on device attachment/detachment.
   // Should be invoked on the UI thread; callbacks will be run on the UI thread.
   void Initialize(base::Closure callback);
 
+  // Register a callback to be called when the initialization is completed. If
+  // the initialization is already completed, the provided callback will be
+  // invoked with the calling stack.
+  void RegisterInitCompletedCallback(base::Closure callback);
+
   // Return true if the storage monitor has already been initialized.
   bool IsInitialized();
 
   // Finds the device that contains |path| and populates |device_info|.
   // Should be able to handle any path on the local system, not just removable
   // storage. Returns false if unable to find the device.
   virtual bool GetStorageInfoForPath(
       const base::FilePath& path,
       StorageInfo* device_info) const = 0;
 
 // TODO(gbillock): make this either unnecessary (implementation-specific) or
 // platform-independent.
 #if defined(OS_WIN)
   // Gets the MTP device storage information specified by |storage_device_id|.
   // On success, returns true and fills in |device_location| with device
   // interface details and |storage_object_id| with the string ID that
   // uniquely identifies the object on the device. This ID need not be
   // persistent across sessions.
   virtual bool GetMTPStorageInfoFromDeviceId(
       const std::string& storage_device_id,
       string16* device_location,
       string16* storage_object_id) const = 0;
 #endif
 
 #if defined(OS_LINUX)
   virtual device::MediaTransferProtocolManager*
       media_transfer_protocol_manager() = 0;
 #endif
 
+  // Returns information for all available storages on the system. It may
+  // return a empty vector if the storage metadata retrieval is not completed
+  // yet on FILE thread.
+  virtual std::vector<StorageInfo> GetAllAvailableStorages() const;

[Lei Zhang, 2013/05/28 08:08:07]

How is this different from GetAttachedStorage() below? Did you want this to
return all storages, removable or fixed? If so, you should check all the
implementations. The CrOS StorageMonitor, for instance, currently only handles
removable devices.

[Hongbo Min, 2013/05/28 14:24:01]

Yes, GetAllAvailableStorages is designed to return the fixed and removabled
storages on the system, while GetAttachedStorage only returns the removable
storages.

[Lei Zhang, 2013/05/28 21:16:44]

I would check and make sure all the per-platform implementations are actually
returning all the storages and not just the removable ones.

+
   // Returns information for attached removable storage.
   std::vector<StorageInfo> GetAttachedStorage() const;
 
   void AddObserver(RemovableStorageObserver* obs);
   void RemoveObserver(RemovableStorageObserver* obs);
 
   std::string GetTransientIdForDeviceId(const std::string& device_id);
   std::string GetDeviceIdForTransientId(const std::string& transient_id) const;
 
   virtual void EjectDevice(
@@ skipping 46 matching lines @@
 
   // Map of all the attached removable storage devices.
   RemovableStorageMap storage_map_;
 
   scoped_ptr<TransientDeviceIds> transient_device_ids_;
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_STORAGE_MONITOR_STORAGE_MONITOR_H_