Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 15896005: Adding setSurface public API method to SkDeferredCanvas (Closed)

Created:
7 years, 7 months ago by Justin Novosad
Modified:
7 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Adding setSurface public API method to SkDeferredCanvas The purpose of this change is to provide an API that Blink 2D canvas layers can use to install a new render target when recovering from a lost graphics context. Committed: https://code.google.com/p/skia/source/detail?r=9276

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -5 lines) Patch
M include/utils/SkDeferredCanvas.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 5 chunks +24 lines, -5 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 2 3 2 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Justin Novosad
PTAL
7 years, 7 months ago (2013-05-24 14:33:23 UTC) #1
reed1
I like the idea, but its starting to make me wonder if we should be ...
7 years, 7 months ago (2013-05-24 14:54:48 UTC) #2
Justin Novosad
About the DeferredSurface idea: I'm not sure I understand what you are suggesting. Removing setDevice ...
7 years, 7 months ago (2013-05-24 15:20:02 UTC) #3
Justin Novosad
New Patch: added unit test
7 years, 7 months ago (2013-05-24 15:21:16 UTC) #4
Justin Novosad
On 2013/05/24 15:21:16, junov wrote: > New Patch: added unit test lgty?
7 years, 7 months ago (2013-05-24 16:08:17 UTC) #5
reed1
sorry, back from lunch. lgtm
7 years, 7 months ago (2013-05-24 17:12:15 UTC) #6
Justin Novosad
7 years, 7 months ago (2013-05-24 17:13:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r9276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698