Add optimize_coding setting for JPEG encoding.

Add optimize_coding setting for JPEG encoding.

Produces smaller encoded output at the expense of encoding time. No visual differences.

sample image 1 (RGB gradients):
default (80): 2.5x slower, 34% smaller
quality 0: 1.7x slower, 52% smaller
quality 20: 2.1x slower, 55% smaller
quality 40: 2.3x slower, 37% smaller
quality 60: 2.5x slower, 36% smaller
quality 100: 3.9x slower, 22% smaller

sample image 2 (photo):
default (80): 2x slower, 8% smaller
quality 0: 1.5x slower, 49% smaller
quality 20: 1.7x slower, 22% smaller
quality 40: 1.9x slower, 15% smaller
quality 60: 1.9x slower, 11% smaller
quality 100: 2x slower, 9% smaller

BUG=skia:3460
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1589593002

Committed: https://skia.googlesource.com/skia/+/0a35620a16b368356888d15771392fb00cbb777d

[dogben, 2016-01-13 22:13:17]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[dogben, 2016-01-13 22:13:19]

Description was changed from

==========
Add optimize_coding setting for JPEG encoding.

BUG=skia:3460
==========

to

==========
Add optimize_coding setting for JPEG encoding.

BUG=skia:3460
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-01-13 22:13:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1589593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1589593002/1

[commit-bot: I haz the power, 2016-01-13 22:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 22:31:42]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-01-14 14:58:19]

benjaminwagner@google.com changed reviewers:
+ scroggo@google.com

[dogben, 2016-01-14 14:58:20]

Google3 tests seem OK with this patch applied.

[scroggo, 2016-01-14 15:38:40]

On 2016/01/14 14:58:20, Ben Wagner wrote:
> Google3 tests seem OK with this patch applied.

Great! What do the tests do?

It would be nice to know what difference this makes. If anyone is using
compression on Android (and I guess they are, given that people have complained
about this), this will affect them.

[scroggo, 2016-01-14 15:44:12]

Also, FWIW, Chromium does *not* set this to TRUE. I don't know the history of
that, though.

[dogben, 2016-01-14 16:21:56]

On 2016/01/14 at 15:38:40, scroggo wrote:
> On 2016/01/14 14:58:20, Ben Wagner wrote:
> > Google3 tests seem OK with this patch applied.
> 
> Great! What do the tests do?

Without going into detail, they encode JPEG images. Comparing previous version
of Skia encoder to the version with this patch applied, the images appear
identical to me, and the file size is much smaller.

> 
> It would be nice to know what difference this makes. If anyone is using
compression on Android (and I guess they are, given that people have complained
about this), this will affect them.

[dogben, 2016-01-14 21:30:54]

Description was changed from

==========
Add optimize_coding setting for JPEG encoding.

BUG=skia:3460
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add optimize_coding setting for JPEG encoding.

Produces smaller encoded output at the expense of encoding time. No visual
differences.

sample image 1 (RGB gradients):
default (80): 2.5x slower, 34% smaller
quality 0: 1.7x slower, 52% smaller
quality 20: 2.1x slower, 55% smaller
quality 40: 2.3x slower, 37% smaller
quality 60: 2.5x slower, 36% smaller
quality 100: 3.9x slower, 22% smaller

sample image 2 (photo):
default (80): 2x slower, 8% smaller
quality 0: 1.5x slower, 49% smaller
quality 20: 1.7x slower, 22% smaller
quality 40: 1.9x slower, 15% smaller
quality 60: 1.9x slower, 11% smaller
quality 100: 2x slower, 9% smaller

BUG=skia:3460
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-14 21:35:16]

LGTM. Thanks!

[dogben, 2016-01-15 02:00:48]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-01-15 02:02:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1589593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1589593002/1

[commit-bot: I haz the power, 2016-01-15 02:13:34]

Description was changed from

==========
Add optimize_coding setting for JPEG encoding.

Produces smaller encoded output at the expense of encoding time. No visual
differences.

sample image 1 (RGB gradients):
default (80): 2.5x slower, 34% smaller
quality 0: 1.7x slower, 52% smaller
quality 20: 2.1x slower, 55% smaller
quality 40: 2.3x slower, 37% smaller
quality 60: 2.5x slower, 36% smaller
quality 100: 3.9x slower, 22% smaller

sample image 2 (photo):
default (80): 2x slower, 8% smaller
quality 0: 1.5x slower, 49% smaller
quality 20: 1.7x slower, 22% smaller
quality 40: 1.9x slower, 15% smaller
quality 60: 1.9x slower, 11% smaller
quality 100: 2x slower, 9% smaller

BUG=skia:3460
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add optimize_coding setting for JPEG encoding.

Produces smaller encoded output at the expense of encoding time. No visual
differences.

sample image 1 (RGB gradients):
default (80): 2.5x slower, 34% smaller
quality 0: 1.7x slower, 52% smaller
quality 20: 2.1x slower, 55% smaller
quality 40: 2.3x slower, 37% smaller
quality 60: 2.5x slower, 36% smaller
quality 100: 3.9x slower, 22% smaller

sample image 2 (photo):
default (80): 2x slower, 8% smaller
quality 0: 1.5x slower, 49% smaller
quality 20: 1.7x slower, 22% smaller
quality 40: 1.9x slower, 15% smaller
quality 60: 1.9x slower, 11% smaller
quality 100: 2x slower, 9% smaller

BUG=skia:3460
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0a35620a16b368356888d15771392fb00cbb777d
==========

[commit-bot: I haz the power, 2016-01-15 02:13:35]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0a35620a16b368356888d15771392fb00cbb777d