Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1589573003: Include the export namespace in the prelinked summary. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include the export namespace in the prelinked summary. This prevents having to traverse the transitive closure of exports when resynthesizing a library from its summary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/834263789f82f25f3eac0f729470198c3f56a0fc

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -112 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 10 chunks +220 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 8 chunks +50 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 8 chunks +106 lines, -35 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 4 chunks +37 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 12 chunks +132 lines, -35 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 14 chunks +188 lines, -19 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 3 chunks +47 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-13 20:43:09 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1589573003/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1589573003/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode770 pkg/analyzer/lib/src/summary/resynthesize.dart:770: Element entryPoint = libraryElement.exportNamespace.get('main'); FunctionElement.MAIN_FUNCTION_NAME https://codereview.chromium.org/1589573003/diff/1/pkg/analyzer/tool/summary/idl.dart File pkg/analyzer/tool/summary/idl.dart ...
4 years, 11 months ago (2016-01-13 20:59:35 UTC) #3
Paul Berry
https://codereview.chromium.org/1589573003/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1589573003/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode770 pkg/analyzer/lib/src/summary/resynthesize.dart:770: Element entryPoint = libraryElement.exportNamespace.get('main'); On 2016/01/13 20:59:35, scheglov wrote: ...
4 years, 11 months ago (2016-01-13 21:15:24 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-13 21:16:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
834263789f82f25f3eac0f729470198c3f56a0fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698