Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1589563002: Add new fuzz binary. (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
kjlubick, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add new fuzz binary. This is designed to have short startup time, for maximum fuzzing throughput. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1589563002 Committed: https://skia.googlesource.com/skia/+/65e5824d3a46c468530aba5de4c11b6c8de4cede

Patch Set 1 #

Patch Set 2 : unused #

Patch Set 3 : trim deps #

Patch Set 4 : simplify gyp #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -7 lines) Patch
A fuzz/Fuzz.h View 1 chunk +43 lines, -0 lines 2 comments Download
A fuzz/FuzzPaeth.cpp View 1 1 chunk +40 lines, -0 lines 0 comments Download
A fuzz/fuzz.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
A gyp/fuzz.gyp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M gyp/most.gyp View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
mtklein_C
4 years, 11 months ago (2016-01-13 20:26:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589563002/20001
4 years, 11 months ago (2016-01-13 20:26:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/3583)
4 years, 11 months ago (2016-01-13 20:28:38 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589563002/40001
4 years, 11 months ago (2016-01-13 20:31:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589563002/60001
4 years, 11 months ago (2016-01-13 20:37:11 UTC) #11
kjlubick
lgtm, with one follow-up question https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h File fuzz/Fuzz.h (right): https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h#newcode41 fuzz/Fuzz.h:41: #define ASSERT(cond) do { ...
4 years, 11 months ago (2016-01-13 20:44:00 UTC) #12
mtklein
https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h File fuzz/Fuzz.h (right): https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h#newcode41 fuzz/Fuzz.h:41: #define ASSERT(cond) do { if (!(cond)) abort(); } while(false) ...
4 years, 11 months ago (2016-01-13 20:48:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589563002/60001
4 years, 11 months ago (2016-01-13 20:49:01 UTC) #17
kjlubick
On 2016/01/13 at 20:48:28, mtklein wrote: > https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h > File fuzz/Fuzz.h (right): > > https://codereview.chromium.org/1589563002/diff/60001/fuzz/Fuzz.h#newcode41 ...
4 years, 11 months ago (2016-01-13 20:55:06 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 20:58:00 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/65e5824d3a46c468530aba5de4c11b6c8de4cede

Powered by Google App Engine
This is Rietveld 408576698