Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: src/core/SkBuffer.cpp

Issue 1589533002: Fix fuzzer-found deserialization bugs (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Fix build error by using explicit cast Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBuffer.h" 8 #include "SkBuffer.h"
9 9
10 #include <string.h> 10 #include <string.h>
(...skipping 17 matching lines...) Expand all
28 28
29 size_t SkRBuffer::skipToAlign4() 29 size_t SkRBuffer::skipToAlign4()
30 { 30 {
31 size_t pos = this->pos(); 31 size_t pos = this->pos();
32 size_t n = SkAlign4(pos) - pos; 32 size_t n = SkAlign4(pos) - pos;
33 fPos += n; 33 fPos += n;
34 return n; 34 return n;
35 } 35 }
36 36
37 bool SkRBufferWithSizeCheck::read(void* buffer, size_t size) { 37 bool SkRBufferWithSizeCheck::read(void* buffer, size_t size) {
38 fError = fError || (fPos + size > fStop); 38 fError = fError || (size > static_cast<size_t>(fStop - fPos));
39 if (!fError && (size > 0)) { 39 if (!fError && (size > 0)) {
40 readNoSizeCheck(buffer, size); 40 readNoSizeCheck(buffer, size);
41 } 41 }
42 return !fError; 42 return !fError;
43 } 43 }
44 44
45 void* SkWBuffer::skip(size_t size) 45 void* SkWBuffer::skip(size_t size)
46 { 46 {
47 void* result = fPos; 47 void* result = fPos;
48 writeNoSizeCheck(nullptr, size); 48 writeNoSizeCheck(nullptr, size);
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 const void* sk_buffer_read_ptr(const void* buffer, void** ptr) 129 const void* sk_buffer_read_ptr(const void* buffer, void** ptr)
130 { 130 {
131 AssertBuffer32(buffer); 131 AssertBuffer32(buffer);
132 if (ptr) 132 if (ptr)
133 *ptr = *(void**)buffer; 133 *ptr = *(void**)buffer;
134 return (const char*)buffer + sizeof(void*); 134 return (const char*)buffer + sizeof(void*);
135 } 135 }
136 136
137 #endif 137 #endif
OLDNEW
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698