chrome/browser/resources/chromeos/login/oobe_screen_user_image.html - Issue 158953002: Spoken feedback sounds for user photo capture/discard at image picker added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.html

Issue 158953002: Spoken feedback sounds for user photo capture/discard at image picker added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Flip-photo accessibility messages added to all 3 screens. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_screen_user_image.css ('k') | chrome/browser/resources/chromeos/login/oobe_screen_user_image.js » ('j') | chrome/browser/resources/chromeos/login/oobe_screen_user_image.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/oobe_screen_user_image.html

diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html

index 22ff800341ec0425304187a6c79ef2c109e90197..08cc51bd119d716b4373225051c02f108461eef2 100644

--- a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html

+++ b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html

@@ -5,7 +5,7 @@

i18n-content="userImageScreenDescription"></p>

</div>

- <grid id="user-image-grid"

+ <grid id="user-image-grid" tabindex="1"

aria-labelledby="user-image-screen-description">

</grid>

@@ -19,10 +19,12 @@

</div>

- <button id="discard-photo" i18n-values="title:discardPhoto"></button>

- <button id="take-photo" i18n-values="title:takePhoto"></button>

+ <button id="discard-photo" i18n-values="title:discardPhoto"

+ tabindex="2"></button>

Nikita (slow) 2014/02/14 11:13:30 nit: 4 spaces indent here and other html files in

+ <button id="take-photo" i18n-values="title:takePhoto" tabindex="2">

+ </button>

<button id="flip-photo" class="custom-appearance"

- i18n-values="title:flipPhoto"></button>

+ i18n-values="title:flipPhoto" tabindex="1"></button>

</div>