Restore creature comforts to fuzz binary

Restore creature comforts to fuzz binary

The hack to remove these niceties didn't seem to make a difference in my
fuzz/s, so we might as well keep them.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1589493006

Committed: https://skia.googlesource.com/skia/+/f5e9782bdea16bbe2983198ed5cd3df8e8af37c1

[mtklein_C, 2016-01-15 13:56:01]

Description was changed from

==========
Restore creature comforts to fuzz binary

The hack to remove these niceties didn't seem to make a difference in my
fuzz/s, so we might as well keep them.

BUG=skia:
==========

to

==========
Restore creature comforts to fuzz binary

The hack to remove these niceties didn't seem to make a difference in my
fuzz/s, so we might as well keep them.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-15 14:01:13]

mtklein@chromium.org changed reviewers:
+ kjlubick@google.com

[kjlubick, 2016-01-15 14:05:20]

lgtm

https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp
File fuzz/fuzz.cpp (right):

https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp#newcode20
fuzz/fuzz.cpp:20: SkDebugf("Usage: %s -b <path/to/fuzzed.data> [-m pattern]\n",
argv[0]);
Protip: afl-fuzz also has a -m flag.  It can be confused sometimes if we supply
a -m flag.  We can keep it in for when we, the humans, run this.  It's just
something to be aware if you ask afl-fuzz to do so.

[mtklein, 2016-01-15 14:06:17]

On 2016/01/15 14:05:20, kjlubick wrote:
> lgtm
> 
> https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp
> File fuzz/fuzz.cpp (right):
> 
> https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp#newcode20
> fuzz/fuzz.cpp:20: SkDebugf("Usage: %s -b <path/to/fuzzed.data> [-m
pattern]\n",
> argv[0]);
> Protip: afl-fuzz also has a -m flag.  It can be confused sometimes if we
supply
> a -m flag.  We can keep it in for when we, the humans, run this.  It's just
> something to be aware if you ask afl-fuzz to do so.

Is --match ok?  We can use -m <pattern> or --match <pattern> equivalently.

[kjlubick, 2016-01-15 14:07:38]

On 2016/01/15 at 14:06:17, mtklein wrote:
> On 2016/01/15 14:05:20, kjlubick wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp
> > File fuzz/fuzz.cpp (right):
> > 
> >
https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp#newcode20
> > fuzz/fuzz.cpp:20: SkDebugf("Usage: %s -b <path/to/fuzzed.data> [-m
pattern]\n",
> > argv[0]);
> > Protip: afl-fuzz also has a -m flag.  It can be confused sometimes if we
supply
> > a -m flag.  We can keep it in for when we, the humans, run this.  It's just
> > something to be aware if you ask afl-fuzz to do so.
> 
> Is --match ok?  We can use -m <pattern> or --match <pattern> equivalently.

Yeah --match is fine.  I guess I trailed off on my last comment before I
mentioned that the away around said problem is to use --match.

[mtklein_C, 2016-01-15 14:08:50]

On 2016/01/15 at 14:07:38, kjlubick wrote:
> On 2016/01/15 at 14:06:17, mtklein wrote:
> > On 2016/01/15 14:05:20, kjlubick wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp
> > > File fuzz/fuzz.cpp (right):
> > > 
> > >
https://codereview.chromium.org/1589493006/diff/40001/fuzz/fuzz.cpp#newcode20
> > > fuzz/fuzz.cpp:20: SkDebugf("Usage: %s -b <path/to/fuzzed.data> [-m
pattern]\n",
> > > argv[0]);
> > > Protip: afl-fuzz also has a -m flag.  It can be confused sometimes if we
supply
> > > a -m flag.  We can keep it in for when we, the humans, run this.  It's
just
> > > something to be aware if you ask afl-fuzz to do so.
> > 
> > Is --match ok?  We can use -m <pattern> or --match <pattern> equivalently.
> 
> Yeah --match is fine.  I guess I trailed off on my last comment before I
mentioned that the away around said problem is to use --match.

It's funny... I just checked my command line and I've been using -m with no
problems:
   afl-fuzz -i input -o fuzz-out/ out/Release/fuzz -m Paeth -b @@

[mtklein_C, 2016-01-15 14:08:57]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-15 14:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1589493006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1589493006/40001

[commit-bot: I haz the power, 2016-01-15 14:19:55]

Description was changed from

==========
Restore creature comforts to fuzz binary

The hack to remove these niceties didn't seem to make a difference in my
fuzz/s, so we might as well keep them.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Restore creature comforts to fuzz binary

The hack to remove these niceties didn't seem to make a difference in my
fuzz/s, so we might as well keep them.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f5e9782bdea16bbe2983198ed5cd3df8e8af37c1
==========

[commit-bot: I haz the power, 2016-01-15 14:19:55]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f5e9782bdea16bbe2983198ed5cd3df8e8af37c1