Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1589493002: Revert shared dart2js messages. (Closed)

Created:
4 years, 11 months ago by floitsch
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert shared dart2js messages. This partially reverts commit e802e26d7b1b6379097c8317d161b073e60fe8be. This reverts commit 6ecea2f559912ca6a04d7397e5995d21481c77b8. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/45f4d82cde7f96fcdfa8f19593f24bfa272ae0da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3237 lines, -4242 lines) Patch
D pkg/compiler/lib/src/diagnostics/dart2js_messages.dart View 1 chunk +0 lines, -3732 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 7 chunks +3237 lines, -508 lines 0 comments Download
M pkg/compiler/pubspec.yaml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
floitsch
Since we are going to generate the dart-files for the analyzer and dart2js we don't ...
4 years, 11 months ago (2016-01-13 17:01:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-13 17:08:51 UTC) #4
floitsch
4 years, 11 months ago (2016-01-13 17:33:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45f4d82cde7f96fcdfa8f19593f24bfa272ae0da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698