[Password Manager] Implements entries sorting and duplicates omitting on chrome://settings/passwords

chrome/browser/ui/passwords/password_manager_presenter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/browser/password_store_consumer.h"
 #include "components/prefs/pref_member.h"
 
 namespace autofill {
 struct PasswordForm;
+
+using DuplicatesMap =

[vabr (Chromium), 2016/03/08 13:09:28]

Please pull DuplicatesMap out of the autofill namespace, there is no reason to
put it in there.

[kolos1, 2016/03/08 15:14:24]

Done.

+    std::multimap<std::string, scoped_ptr<autofill::PasswordForm>>;

[vabr (Chromium), 2016/03/08 13:09:28]

#include <ma> for multimap

[kolos1, 2016/03/08 15:14:24]

Done.

 }
 
 class PasswordUIView;
 
 class Profile;
 
 // Contains the common logic used by a PasswordUIView to
 // interact with PasswordStore. It provides completion callbacks for
 // PasswordStore operations and updates the view on PasswordStore changes.
 class PasswordManagerPresenter
@@ skipping 33 matching lines @@
  private:
   friend class PasswordManagerPresenterTest;
 
   // Returns the password store associated with the currently active profile.
   password_manager::PasswordStore* GetPasswordStore();
 
   // Sets the password and exception list of the UI view.
   void SetPasswordList();
   void SetPasswordExceptionList();
 
+  // Sort entries of |list| based on sort key. The key is the concatenation of
+  // origin, username, hashed password and entry type (non-Android credential,
+  // Android w/ affiliated web realm or Android w/o affiliated web realm). If
+  // there is several forms with the same key, the duplicates are moved from

[vabr (Chromium), 2016/03/08 13:09:28]

nit: To clarify that "duplicates" exclude the first occurrence, consider
rephrasing:
"...the same key, all such forms but the first one are stored in |duplicates|
instead of |list|.

I would omit "(the multimap from sort key to forms)" and instead note  next to
the definition of DuplicatesMap that the std::string is a sort key.

[kolos1, 2016/03/08 15:14:24]

Done.

+  // |list| to |duplicates| (the multimap from sort key to forms).
+  // |username_and_password_in_key| defines whether username and  hashed

[vabr (Chromium), 2016/03/08 13:09:28]

The last sentence is not completely clear -- from the above comment it looks
like the username and the hashed comment are always included.

[kolos1, 2016/03/08 15:14:24]

Done.

+  // password are included in sort key.
+  void SortEntriesAndHideDuplicates(
+      const std::string& languages,
+      std::vector<scoped_ptr<autofill::PasswordForm>>* list,
+      autofill::DuplicatesMap* duplicates_,

[vabr (Chromium), 2016/03/08 13:09:28]

nit: Remove the trailing underscore in "duplicates_", this is not a member
variable.

[kolos1, 2016/03/08 15:14:24]

Done.

+      bool username_and_password_in_key);
+
   // A short class to mediate requests to the password store.
   class ListPopulater : public password_manager::PasswordStoreConsumer {
    public:
     explicit ListPopulater(PasswordManagerPresenter* page);
     ~ListPopulater() override;
 
     // Send a query to the password store to populate a list.
     virtual void Populate() = 0;
 
    protected:
@@ skipping 25 matching lines @@
     void OnGetPasswordStoreResults(
         ScopedVector<autofill::PasswordForm> results) override;
   };
 
   // Password store consumer for populating the password list and exceptions.
   PasswordListPopulater populater_;
   PasswordExceptionListPopulater exception_populater_;
 
   std::vector<scoped_ptr<autofill::PasswordForm>> password_list_;
   std::vector<scoped_ptr<autofill::PasswordForm>> password_exception_list_;
+  autofill::DuplicatesMap password_duplicates_;
+  autofill::DuplicatesMap password_exception_duplicates_;
 
   // Whether to show stored passwords or not.
   BooleanPrefMember show_passwords_;
 
   // Indicates whether or not the password manager should require the user to
   // reauthenticate before revealing plaintext passwords.
   const bool require_reauthentication_;
 
   // The last time the user was successfully authenticated.
   // Used to determine whether or not to reveal plaintext passwords.
   base::TimeTicks last_authentication_time_;
 
   // UI view that owns this presenter.
   PasswordUIView* password_view_;
 
   // User pref for storing accept languages.
   std::string languages_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerPresenter);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_