Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 15894029: suppress memory leak from ShellBrowserMainParts::PreMainMessageLoopRun (Closed)

Created:
7 years, 6 months ago by zhaoqin
Modified:
7 years, 6 months ago
Reviewers:
nilesh
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

suppress memory leak from ShellBrowserMainParts::PreMainMessageLoopRun TBR=nileshagrawal@chromium.org BUG=246359 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zhaoqin
7 years, 6 months ago (2013-06-03 21:37:44 UTC) #1
zhaoqin
Committed patchset #1 manually as r203779 (presubmit successful).
7 years, 6 months ago (2013-06-03 21:40:14 UTC) #2
jam
this call stack is too generic, it will basically cover all allocations during content_browsertests.
7 years, 6 months ago (2013-06-03 21:58:04 UTC) #3
zhaoqin
On 2013/06/03 21:58:04, jam wrote: > this call stack is too generic, it will basically ...
7 years, 6 months ago (2013-06-03 22:18:10 UTC) #4
jam
On 2013/06/03 22:18:10, zhaoqin wrote: > On 2013/06/03 21:58:04, jam wrote: > > this call ...
7 years, 6 months ago (2013-06-04 00:36:01 UTC) #5
jam
ping
7 years, 6 months ago (2013-06-04 16:21:27 UTC) #6
zhaoqin
7 years, 6 months ago (2013-06-04 18:32:16 UTC) #7
Message was sent while issue was closed.
On 2013/06/04 16:21:27, jam wrote:
> ping

it only suppresses the memory leaks that allocated from PreMainMessageLoopRun,
so should be fine.

Powered by Google App Engine
This is Rietveld 408576698