Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 15894005: Moving updateClipConservativelyUsingBounds into SkCanvas (Closed)

Created:
7 years, 6 months ago by Justin Novosad
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Moving updateClipConservativelyUsingBounds into SkCanvas This method is being moved from SkPictureRecord to become a protected member of SkCanvas so that other classes derived from SkCanvas can use it. This Patch also applies the fix provided by updateClipConservativelyUsingBounds to SkPictureUtils::GatherPixelRefs BUG=https://code.google.com/p/chromium/issues/detail?id=244893 Committed: https://code.google.com/p/skia/source/detail?r=9326

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -76 lines) Patch
M include/core/SkCanvas.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +68 lines, -0 lines 1 comment Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +2 lines, -72 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Justin Novosad
PTAL Purpose: allow chromium's AnalysisCanvas and friends to track clip bounds correctly.
7 years, 6 months ago (2013-05-29 16:58:37 UTC) #1
reed1
lgtm w/ request for comment explaining the use of SkCanvas:: in calls to this. https://codereview.chromium.org/15894005/diff/1/src/core/SkCanvas.cpp ...
7 years, 6 months ago (2013-05-29 18:54:01 UTC) #2
Justin Novosad
7 years, 6 months ago (2013-05-29 19:09:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9326 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698