src/compiler/wasm-compiler.cc - Issue 1589363002: [turbofan] Add the RoundInt32ToFloat32 operator to turbofan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1589363002: [turbofan] Add the RoundInt32ToFloat32 operator to turbofan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/wasm-compiler.cc

diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc

index 17065d61b4aac0b34adefab2a945af092250b159..a198078ada10651ff6287c4e4700b4a3bf6b5e19 100644

--- a/src/compiler/wasm-compiler.cc

+++ b/src/compiler/wasm-compiler.cc

@@ -696,9 +696,7 @@ Node* WasmGraphBuilder::Unop(wasm::WasmOpcode opcode, Node* input) {

op = m->ChangeUint32ToFloat64();

break;

case wasm::kExprF32SConvertI32:

- op = m->ChangeInt32ToFloat64(); // TODO(titzer): two conversions

- input = graph()->NewNode(op, input);

- op = m->TruncateFloat64ToFloat32();

+ op = m->RoundInt32ToFloat32();

break;

case wasm::kExprF32UConvertI32:

op = m->ChangeUint32ToFloat64();

« no previous file with comments | « src/compiler/verifier.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »