Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1589323002: [runtime] Unify the ToObject handling. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Unify the ToObject handling. Unify Object::ToObject and Execution::ToObject, and unify all users to go to Object::ToObject directly. Also remove some dead code from the frame details debug API. R=yangguo@chromium.org Committed: https://crrev.com/a6900e0cb763345750b4bd56153df3a94aa01a38 Cr-Commit-Position: refs/heads/master@{#33327}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -63 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 4 chunks +9 lines, -6 lines 1 comment Download
M src/execution.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/execution.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M src/messages.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -19 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-15 12:36:51 UTC) #1
Benedikt Meurer
Hey Yang, Finishing the ToObject story. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-15 12:37:42 UTC) #2
Yang
lgtm. https://codereview.chromium.org/1589323002/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1589323002/diff/1/src/builtins.cc#newcode1437 src/builtins.cc:1437: // TODO(bmeurer): Do we really care about the ...
4 years, 11 months ago (2016-01-15 12:42:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589323002/1
4 years, 11 months ago (2016-01-15 12:50:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 12:59:45 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 13:00:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6900e0cb763345750b4bd56153df3a94aa01a38
Cr-Commit-Position: refs/heads/master@{#33327}

Powered by Google App Engine
This is Rietveld 408576698