Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1589293003: Add a corpus test case for issue 1580773002

Created:
4 years, 11 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a corpus test case for issue 1580773002 BUG=pdfium:354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A fx/xfa/number_date_as_name.pdf View Binary file 0 comments Download
A fx/xfa/number_date_as_name_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 8 (1 generated)
jun_fang
4 years, 11 months ago (2016-01-15 16:33:44 UTC) #2
jun_fang
On 2016/01/15 16:33:44, jun_fang wrote: For this case, I created a xfa file for testing ...
4 years, 11 months ago (2016-01-15 16:49:16 UTC) #3
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-15 16:50:14 UTC) #4
Tom Sepez
On 2016/01/15 16:50:14, Tom Sepez wrote: > lgtm Jun raised the issue of how to ...
4 years, 11 months ago (2016-01-15 16:56:31 UTC) #5
Tom Sepez
On 2016/01/15 16:56:31, Tom Sepez wrote: > On 2016/01/15 16:50:14, Tom Sepez wrote: > > ...
4 years, 11 months ago (2016-01-19 22:36:37 UTC) #6
jun_fang
On 2016/01/19 22:36:37, Tom Sepez wrote: > On 2016/01/15 16:56:31, Tom Sepez wrote: > > ...
4 years, 11 months ago (2016-01-20 04:24:37 UTC) #7
Lei Zhang
4 years, 10 months ago (2016-01-26 02:37:35 UTC) #8
On 2016/01/20 04:24:37, jun_fang wrote:
> Hi Tom and Lei,
> 
> I need your help to land this test file and its expected pngs on 
> different platforms for me. The expected pngs generated on my PC
> are different with the ones generated on Google's. It will cause 
> corpus test failures if I land the expected pngs.  Thanks!

IIRC, you are using Ubuntu 12.04. Have you considered upgrading to Ubuntu 14.04?
It should be relatively painless and then you'll have the same developement
environment as the test bots.

Powered by Google App Engine
This is Rietveld 408576698