Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: net/spdy/spdy_network_transaction_spdy3_unittest.cc

Issue 15892015: [SPDY] Refactor SpdyStream state machine (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove default: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_session_spdy2_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_network_transaction_spdy3_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_spdy3_unittest.cc b/net/spdy/spdy_network_transaction_spdy3_unittest.cc
index 12fe22f634d9ab1c5c335d2b0167456a215e49bf..997d63399962bcd207fac11728bf3fc4448c2de4 100644
--- a/net/spdy/spdy_network_transaction_spdy3_unittest.cc
+++ b/net/spdy/spdy_network_transaction_spdy3_unittest.cc
@@ -2446,8 +2446,9 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, FlowControlStallResume) {
// TODO(satorux): This is because of the weirdness in reading the request
// body in OnSendBodyComplete(). See crbug.com/113107.
EXPECT_TRUE(upload_data_stream.IsEOF());
- // But the body is not yet fully sent (kUploadData is not yet sent).
- EXPECT_FALSE(stream->stream()->body_sent());
+ // But the body is not yet fully sent (kUploadData is not yet sent)
+ // since we're send-stalled.
+ EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control());
data.ForceNextRead(); // Read in WINDOW_UPDATE frame.
rv = callback.WaitForResult();
@@ -2548,8 +2549,8 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, FlowControlStallResumeAfterSettings) {
// TODO(satorux): This is because of the weirdness in reading the request
// body in OnSendBodyComplete(). See crbug.com/113107.
EXPECT_TRUE(upload_data_stream.IsEOF());
- // But the body is not yet fully sent (kUploadData is not yet sent).
- EXPECT_FALSE(stream->stream()->body_sent());
+ // But the body is not yet fully sent (kUploadData is not yet sent)
+ // since we're send-stalled.
EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control());
data.ForceNextRead(); // Read in SETTINGS frame to unstall.
@@ -2658,8 +2659,9 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, FlowControlNegativeSendWindowSize) {
// TODO(satorux): This is because of the weirdness in reading the request
// body in OnSendBodyComplete(). See crbug.com/113107.
EXPECT_TRUE(upload_data_stream.IsEOF());
- // But the body is not yet fully sent (kUploadData is not yet sent).
- EXPECT_FALSE(stream->stream()->body_sent());
+ // But the body is not yet fully sent (kUploadData is not yet sent)
+ // since we're send-stalled.
+ EXPECT_TRUE(stream->stream()->send_stalled_by_flow_control());
data.ForceNextRead(); // Read in WINDOW_UPDATE or SETTINGS frame.
rv = callback.WaitForResult();
« no previous file with comments | « net/spdy/spdy_http_stream.cc ('k') | net/spdy/spdy_session_spdy2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698