[SPDY] Refactor SpdyStream state machine

[SPDY] Refactor SpdyStream state machine

In particular, remove STATE_SEND_BODY,
STATE_SEND_BODY_COMPLETE, SPDY_WAITING_FOR_RESPONSE and
instead add logic to detect when we receive an out-of-place
response.

Fix tests that were using the wrong SpdyStreamType and
weren't using a delegate.

Add various TODOs.

BUG=243643
R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202810

[akalin, 2013-05-29 02:38:20]

+rch for review

[Ryan Hamilton, 2013-05-29 03:05:33]

lgtm

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc
File net/spdy/spdy_stream.cc (right):

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc#newco...
net/spdy/spdy_stream.cc:409: default:
If there is not another value for the enum, I think you can leave out default:,
right?   (Which is nice because if another value were ever added, the compiler
would complain.)

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc#newco...
net/spdy/spdy_stream.cc:847: default:
ditto.  I think you can drop this case, right?

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.h
File net/spdy/spdy_stream.h (left):

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.h#oldcod...
net/spdy/spdy_stream.h:382: int ProcessJustCompletedFrame(int result, State
io_pending_state);
Wow, cool

[akalin, 2013-05-29 03:12:45]

committing soon!

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc
File net/spdy/spdy_stream.cc (right):

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc#newco...
net/spdy/spdy_stream.cc:409: default:
On 2013/05/29 03:05:33, Ryan Hamilton wrote:
> If there is not another value for the enum, I think you can leave out
default:,
> right?   (Which is nice because if another value were ever added, the compiler
> would complain.)

Unfortunately, no. since the enum has to be at least two bits, 3 is a valid
value of the enum (= SPDY_REQUEST_RESPONSE_STREAM | SPDY_PUSH_STREAM).

https://codereview.chromium.org/15892015/diff/1/net/spdy/spdy_stream.cc#newco...
net/spdy/spdy_stream.cc:847: default:
On 2013/05/29 03:05:33, Ryan Hamilton wrote:
> ditto.  I think you can drop this case, right?  

ditto.

[commit-bot: I haz the power, 2013-05-29 03:12:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/15892015/1

[akalin, 2013-05-29 03:41:37]

okay, removed default: cases

[commit-bot: I haz the power, 2013-05-29 03:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/15892015/2016

[akalin, 2013-05-29 07:58:15]

Committed patchset #2 manually as r202810 (presubmit successful).