[modules] Support parsing anonymous default exports

[modules] Support parsing anonymous default exports

This includes anonymous Function, Generator, and Class declarations when
preceded by 'export default'. Parsing only at the moment, nothing useful is
done with the parsed Function/ClassLiteral.

BUG=v8:1569
LOG=n

Committed: https://crrev.com/25532be593bd80c9e7b3fac4ee50491159902e93
Cr-Commit-Position: refs/heads/master@{#33344}

[adamk, 2016-01-14 23:04:31]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[caitp (gmail), 2016-01-14 23:12:53]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2016-01-14 23:12:53]

some small things, but why not

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1577: default_export = ParseFunctionLiteral(
per 14.1.20, you probably want the SetFunctionName(F, "default") here, rather
than passing nullptr for the name

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1595: default_export = ParseClassLiteral(
here too, per 15.2.3.11

[adamk, 2016-01-15 00:06:30]

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1577: default_export = ParseFunctionLiteral(
On 2016/01/14 23:12:53, caitp wrote:
> per 14.1.20, you probably want the SetFunctionName(F, "default") here, rather
> than passing nullptr for the name

Done.

https://codereview.chromium.org/1589173002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1595: default_export = ParseClassLiteral(
On 2016/01/14 23:12:53, caitp wrote:
> here too, per 15.2.3.11

Done.

[Dan Ehrenberg, 2016-01-15 01:59:12]

lgtm

https://codereview.chromium.org/1589173002/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1589173002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1628: // and add an export entry with "*default*" as the
local name.
To check my understanding, the above TODO refers to making an AddLocalExport
call? Initially I thought this was just referring to double-export-default
checking.

https://codereview.chromium.org/1589173002/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1589173002/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5673: "export class extends C {}",
For completeness, export function*() {}; ?

[adamk, 2016-01-15 20:09:54]

https://codereview.chromium.org/1589173002/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1589173002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1628: // and add an export entry with "*default*" as the
local name.
On 2016/01/15 01:59:12, Dan Ehrenberg wrote:
> To check my understanding, the above TODO refers to making an AddLocalExport
> call? Initially I thought this was just referring to double-export-default
> checking.

Yeah, though I think the TODO predates the existence of AddLocalExport().

https://codereview.chromium.org/1589173002/diff/20001/test/cctest/test-parsin...
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1589173002/diff/20001/test/cctest/test-parsin...
test/cctest/test-parsing.cc:5673: "export class extends C {}",
On 2016/01/15 01:59:12, Dan Ehrenberg wrote:
> For completeness, export function*() {}; ?

Done.

[adamk, 2016-01-15 20:10:03]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-01-15 20:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1589173002/#ps40001
(title: "Add negative generator test")

[commit-bot: I haz the power, 2016-01-15 20:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1589173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1589173002/40001

[commit-bot: I haz the power, 2016-01-15 20:38:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-15 20:39:10]

Description was changed from

==========
[modules] Support parsing anonymous default exports

This includes anonymous Function, Generator, and Class declarations when
preceded by 'export default'. Parsing only at the moment, nothing useful is
done with the parsed Function/ClassLiteral.

BUG=v8:1569
LOG=n
==========

to

==========
[modules] Support parsing anonymous default exports

This includes anonymous Function, Generator, and Class declarations when
preceded by 'export default'. Parsing only at the moment, nothing useful is
done with the parsed Function/ClassLiteral.

BUG=v8:1569
LOG=n

Committed: https://crrev.com/25532be593bd80c9e7b3fac4ee50491159902e93
Cr-Commit-Position: refs/heads/master@{#33344}
==========

[commit-bot: I haz the power, 2016-01-15 20:39:11]

Patchset 3 (id:??) landed as
https://crrev.com/25532be593bd80c9e7b3fac4ee50491159902e93
Cr-Commit-Position: refs/heads/master@{#33344}