Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1589133003: [Downloads] Disable resumption by default. (Closed)

Created:
4 years, 11 months ago by asanka
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Mark download resumption as disabled by default. Feature state will be controlled via a server-side field trial. BUG=7648 BUG=579108 Committed: https://crrev.com/3e0b9d7839072b59ac19110e1e6666b93716ed41 Cr-Commit-Position: refs/heads/master@{#370138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
asanka
PTAL?
4 years, 11 months ago (2016-01-15 01:43:43 UTC) #4
asanka
On 2016/01/15 01:43:43, asanka wrote: > PTAL? +jam : PTAL? asvitkine: Off the hook. I ...
4 years, 11 months ago (2016-01-15 01:46:55 UTC) #7
Alexei Svitkine (slow)
lgtm please modify your CL description to not say Finch, since that's an internal code ...
4 years, 11 months ago (2016-01-15 19:21:39 UTC) #9
jam
lgtm
4 years, 11 months ago (2016-01-15 19:25:28 UTC) #10
asanka
Thanks! Updated CL description to refer to 'server-side field trial' instead of Finch.
4 years, 11 months ago (2016-01-19 16:34:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589133003/1
4 years, 11 months ago (2016-01-19 16:35:24 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 17:49:19 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 17:51:04 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e0b9d7839072b59ac19110e1e6666b93716ed41
Cr-Commit-Position: refs/heads/master@{#370138}

Powered by Google App Engine
This is Rietveld 408576698