Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 158913003: Traitify ParserBase and move functions there. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Traitify ParserBase and move functions there. (Second try, with fixes. First try: https://codereview.chromium.org/149913006/ ) The long-term goal is to move all recursive descent functions from Parser and PreParser into ParserBase, but first they need to be unified. Notes: - The functions moved in this CL: ParseIdentifier, ParseIdentifierName, ParseIdentifierNameOrGetOrSet, ParseIdentifierOrStrictReservedWord. - IOW, this CL removes Parser::ParseIdentifier and PreParser::ParseIdentifier and adds ParserBase::ParseIdentifier, etc. - Error reporting used to require virtual funcs; now error reporting is moved to the Traits too, and ParserBase no longer needs to be virtual. - I had to move PreParser::Identifier out of the PreParser class, because otherwise PreParserTraits cannot use it in a typedef. BUG=v8:3126 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -673 lines) Patch
M src/parser.h View 7 chunks +38 lines, -32 lines 0 comments Download
M src/parser.cc View 22 chunks +98 lines, -274 lines 0 comments Download
M src/preparser.h View 12 chunks +418 lines, -193 lines 0 comments Download
M src/preparser.cc View 14 chunks +86 lines, -172 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM (rubber-stamped).
6 years, 10 months ago (2014-02-10 17:35:12 UTC) #1
marja
6 years, 10 months ago (2014-02-11 09:35:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698