Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 15891015: Allow a space after -o in dart2js option parsing. (Closed)

Created:
7 years, 6 months ago by kasperl
Modified:
7 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow a space after -o in dart2js option parsing. Is too much of a hack? We've talked about using the 'args' package for options parsing, but for now I really just want to make it easier to run dart2js without surprises. R=ahe@google.com BUG=http://dartbug.com/3379 Committed: https://code.google.com/p/dart/source/detail?r=23398

Patch Set 1 #

Patch Set 2 : Generalize handling of multi-arg options. #

Patch Set 3 : Use iterator. #

Total comments: 1

Patch Set 4 : Fix callback type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 2 3 6 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kasperl
7 years, 6 months ago (2013-05-30 07:21:07 UTC) #1
ahe
I'll review the code when I'm at my desk. From what I could gleam on ...
7 years, 6 months ago (2013-05-30 07:37:55 UTC) #2
kasperl
PTAL. I decided to generalize the handling a little bit.
7 years, 6 months ago (2013-05-30 08:10:18 UTC) #3
kasperl
PTAL. Now I'm passing an iterator to the option handler (optionally).
7 years, 6 months ago (2013-05-30 09:58:07 UTC) #4
ahe
https://codereview.chromium.org/15891015/diff/6001/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/15891015/diff/6001/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode212 sdk/lib/_internal/compiler/implementation/dart2js.dart:212: new OptionHandler('-[chv?]+', handleShortOptions), I would expect a type error ...
7 years, 6 months ago (2013-05-30 10:02:49 UTC) #5
kasperl
PTAL. Thanks for spotting my stupid mistakes :-)
7 years, 6 months ago (2013-05-30 10:45:42 UTC) #6
ahe
LGTM!
7 years, 6 months ago (2013-05-30 11:28:33 UTC) #7
kasperl
7 years, 6 months ago (2013-05-30 12:11:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r23398 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698