build/android/pylib/__init__.py - Issue 15891002: Android: allows using adb from a chromium checkout without envsetup.sh

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/init.py

Issue 15891002: Android: allows using adb from a chromium checkout without envsetup.sh (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Print message Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 import os

	6 import subprocess

	7

	8

	9 if not os.environ.get('ANDROID_SDK_ROOT'):

	10 # If envsetup.sh hasn't been sourced and there's no adb in the path,

	11 # set it here.

	12 try:

	13 subprocess.call(['adb', 'version'])
	Isaac (away) 2013/05/24 19:17:01 How about 'which adb' instead? Also you need to p How about 'which adb' instead? Also you need to pipe output /stderr to null bulach 2013/05/28 09:12:25 good points, done both. Show quoted text On 2013/05/24 19:17:01, Isaac wrote: > How about 'which adb' instead? Also you need to pipe output /stderr to null good points, done both.
	14 except OSError:

	15 print 'No adb found in $PATH, fallback to checked in binary.'

	16 os.environ['PATH'] += os.pathsep + os.path.abspath(os.path.join(

	17 os.path.dirname(__file__),

	18 '..', '..', '..',
	Isaac (away) 2013/05/24 19:17:01 can we import constants.py and use the sdk_dir her can we import constants.py and use the sdk_dir here? bulach 2013/05/28 09:12:25 I don't think so, this is the module's __init__, I Show quoted text On 2013/05/24 19:17:01, Isaac wrote: > can we import constants.py and use the sdk_dir here? I don't think so, this is the module's __init__, I think its constants.py is not yet available.
	19 'third_party', 'android_tools', 'sdk', 'platform-tools'))

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Side by Side Diff: build/android/pylib/__init__.py

Side by Side Diff: build/android/pylib/init.py