Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1589043002: Add tests for computation of constant expressions involving ?? (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for computation of constant expressions involving ?? R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/1e9326d13f5c670ccd1a0ed215477519daef9370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -64 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 23 chunks +108 lines, -64 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 11 months ago (2016-01-14 18:25:50 UTC) #2
Paul Berry
lgtm
4 years, 11 months ago (2016-01-14 18:49:53 UTC) #3
Brian Wilkerson
4 years, 11 months ago (2016-01-14 18:55:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e9326d13f5c670ccd1a0ed215477519daef9370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698